reduce cognitive complexity

CMU-17313Q · Sep 3, 2024 · b11f015 · b11f015
1 parent 09ad0fe
commit b11f015
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 22 deletions.
diff --git a/dump.rdb b/dump.rdb
diff --git a/src/controllers/helpers.js b/src/controllers/helpers.js
@@ -20,6 +20,31 @@ const helpers = module.exports;
 const relative_path = nconf.get('relative_path');
 const url = nconf.get('url');
 
+const handleSuccessfulResponse = (statusCode, res, payload) => {
+	if (res.req.loggedIn) {
+		res.set('cache-control', 'private');
+	}
+
+	let code = 'ok';
+	let message = 'OK';
+	switch (statusCode) {
+		case 202:
+			code = 'accepted';
+			message = 'Accepted';
+			break;
+
+		case 204:
+			code = 'no-content';
+			message = 'No Content';
+			break;
+	}
+
+	res.status(statusCode).json({
+		status: { code, message },
+		response: payload || {},
+	});
+};
+
 helpers.noScriptErrors = async function (req, res, error, httpStatus) {
 	if (req.body.noscript !== 'true') {
 		if (typeof error === 'string') {
@@ -454,28 +479,7 @@ helpers.formatApiResponse = async (statusCode, res, payload) => {
 	}
 
 	if (String(statusCode).startsWith('2')) {
-		if (res.req.loggedIn) {
-			res.set('cache-control', 'private');
-		}
-
-		let code = 'ok';
-		let message = 'OK';
-		switch (statusCode) {
-			case 202:
-				code = 'accepted';
-				message = 'Accepted';
-				break;
-
-			case 204:
-				code = 'no-content';
-				message = 'No Content';
-				break;
-		}
-
-		res.status(statusCode).json({
-			status: { code, message },
-			response: payload || {},
-		});
+		handleSuccessfulResponse(statusCode, res, payload);
 	} else if (payload instanceof Error || typeof payload === 'string') {
 		const message = payload instanceof Error ? payload.message : payload;
 		const response = {};