Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings - Add missing setting type to header & wiki additions #1693

Merged
merged 1 commit into from
Sep 29, 2024

Conversation

tuntematonjr
Copy link
Contributor

When merged this pull request will:

  • Add missing parameter type to header. No actual code edits.

Also wiki is missing Time param, so following line could be added.

https://github.com/CBATeam/CBA_A3/wiki/CBA-Settings-System#arguments-of-cba_fnc_addsetting

_settingType - Type of setting. Can be "CHECKBOX", "EDITBOX", "LIST", "SLIDER" or "COLOR" <STRING>
->
_settingType - Type of setting. Can be "CHECKBOX", "EDITBOX", "LIST", "SLIDER", "COLOR" or "TIME" <STRING>

https://github.com/CBATeam/CBA_A3/wiki/CBA-Settings-System#supported-setting-types-_settingtype

* **TIME:** Similar to a slider, but allows input in the HH:MM:SS format and returns the corresponding value in seconds.

https://github.com/CBATeam/CBA_A3/wiki/CBA-Settings-System#setting-type-specific-arguments-_valueinfo

### Time:
* 0: Minimum (lowest possible value) <NUMBER>
* 1: Maximum (highest possible value) <NUMBER>
* 2: Default value <NUMBER>```

@PabstMirror
Copy link
Contributor

Applied wiki changes: https://github.com/CBATeam/CBA_A3/wiki/CBA-Settings-System/_compare/743d6340d60e22f6d0e2a3a0126bc66f684e3770...2874a8416c2fc4c5244446e10c4d85d5dc312944

@PabstMirror PabstMirror added this to the 3.18.0 milestone Sep 29, 2024
@PabstMirror PabstMirror merged commit b50164b into CBATeam:master Sep 29, 2024
4 checks passed
@tuntematonjr
Copy link
Contributor Author

Applied wiki changes: https://github.com/CBATeam/CBA_A3/wiki/CBA-Settings-System/_compare/743d6340d60e22f6d0e2a3a0126bc66f684e3770...2874a8416c2fc4c5244446e10c4d85d5dc312944

Otherwise good, but this part got splited from color to under time

The array size can be 3 or 4, depending on the passed default value. The fourth element will represent the opacity ("alpha value").

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants