-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setting - Added multiline setting parsing support #1581
Setting - Added multiline setting parsing support #1581
Conversation
Wiki page amended. |
Something that just came to mind is forceUnicode, where is says trim supports the usage of I used this string: To test I added Ultimately, what I'm trying to convey is that I am slightly concerned about non-ASCII chars being a potential problem, but at the same time the small amount of testing I did suggests it's fine. EDIT: Minor correction: |
Did you actually have a |
No, that was a typo on my part, it was |
Confirming that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready?
Testing by others would be nice. |
Tested this with
Came up in-game as it works. |
In addition, it successfully parsed https://github.com/Theseus-Aegis/Mods/blob/96ce4f4a1c20029ad722a4cd992a314b461e6f7e/addons/cba_settings/cba_settings.sqf in its entirety as well (tested single-line and multi-line |
When merged this pull request will:
CBA_settings_fnc_parse
parse settings that are over multiple lines.force
now needs to be followed by a space, tab, LF or CR in order for it to not be considered a setting.E.g:
Previously:
Now:
I have tested it, but not extensively.