-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add magazine wells for VN CDLC #1537
Add magazine wells for VN CDLC #1537
Conversation
Should the VN config entries be conditional? VN doesn't utilize magazine wells today so the configs won't clash with (potentially) later loaded VN config. |
I think having all the CDLC as conditional would be good, just like you've done in #1538 |
a9c67f4
to
bde02f7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't find any errors during testing
ref #1601
full dump
|
@PabstMirror the inheritance issues should be sorted now |
When merged this pull request will: