Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing locale param to Content and Page types #109

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

soniaklimas
Copy link

Added the missing locale parameter in butter.d.ts to support localized content retrieval.

This change ensures we can pass locale directly when retrieving pages and content, maintaining type safety and avoiding workarounds in code.

@courcelan courcelan self-requested a review November 7, 2024 18:13
@courcelan
Copy link
Contributor

hi @soniaklimas thanks for this PR! We do have a recently accepted one that seems to cover this issue, but we will keep your PR open and take another look once those other open PRs are merged into master.

We appreciate your help!

Copy link
Contributor

@courcelan courcelan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

holding for re-review after merging in #108

@ViolanteCodes
Copy link
Contributor

@soniaklimas are you able to resolve the merge conflict and prefix your commit message with fix? If not, let us know and we will handle, thank you!

@soniaklimas
Copy link
Author

@soniaklimas are you able to resolve the merge conflict and prefix your commit message with fix? If not, let us know and we will handle, thank you!

I’d appreciate it if you could handle prefixing my commit. Please let me know if there’s anything else you need from my end.

@ViolanteCodes
Copy link
Contributor

@soniaklimas On review, it looks like these changes were already added with the last change to master - @courcelan can you confirm? If so, I will close this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants