Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P 008/create registration form #11

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

BryanCI
Copy link
Collaborator

@BryanCI BryanCI commented May 30, 2020

Description

Please include a summary of the change and relevant motivation and context.
List any dependencies that are required for this change.

All pull requests should be related to open issues. Indicate the issue(s) bellow and remove this line:
Fixes #(issue number 1) #(issue number 2 if applicable)

How Has This Been Tested?

Please describe in detail how you tested your changes.
Include details of your testing environment, and the tests you ran to see how your change affects other areas of the code etc.

Screenshots (if applicable, else remove this line / section)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added necessary inline code documentation
  • I have added tests that prove my fix is effective and that this feature works
  • New and existing unit tests pass locally with my changes

codacy-badger and others added 4 commits May 15, 2020 11:54
Add a Codacy badge to README.md
* Install dependencies: main -> react, react-admin, *-polyfill and dev -> immutable, dotenv, husky and lint-staged

* Install eslint-plugin-react and update eslint config

* Refactor <App/> to render <Admin/> (entry point)

* Refactor the index.(html|js|css) serve the react app

* Add a serviceWorker file (prepare for PWA setup)

* Install "@babel/preset-react" and "react-test-renderer"

* Refactor babel and jest config, testingEnvironment -> revert to target "jsdom" (default)

* Write "rendering" tests for <App />

* Refactor to follow code standard

* Downgrade "react-test-renderer" to 16.9.0, and install "stylelint" (standard config)

* Declare .stylelintrc (ran "npx stylelint src/index.css") and update .lintstagedrc
demo commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants