eslint updates #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaydanielsencision
requested review from
pskenny,
mkavanagh,
kvaghela,
johnmbw,
yfernando-bw,
dsaladacision,
thoufic-shahul and
aaronmassicotte
pskenny
reviewed
Aug 30, 2024
| "version": "0.1.2", | ||
| "homepage": "https://github.com/nunukim/node-xlsx-stream", | ||
| "version": "0.2.0", | ||
| "homepage": "https://github.com/BrandwatchLtd/node-xlsx-stream", | ||
| "author": { |
There was a problem hiding this comment.
Do we need to update the author info too? Seems out of date since the urls redirect oddly and doesn't apply to this codebase. Carried over from initial fork maybe?
There was a problem hiding this comment.
I think the etiquette with forks is to update the author (to reflect who should be contacted w.r.t. the fork) but list the original author in contributors. The author field is optional - for our case might be best to leave it out.
There was a problem hiding this comment.
I was thinking this might constituent as copyright attribution required by the MIT licence but it is, in fact, 100% not and the author copyright is in the LICENCE file anyway. Silly me.
mkavanagh
approved these changes
Aug 30, 2024
pskenny
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes