Fix UpsertCondition due to Solr 7 encoding of String types in javabin… #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… format. This relates to a change in behaviour introduced in SOLR-12983 which affected how javabin encodes strings, they are ByteArrayUtf8CharSequence and not String objects (but both are CharSequence). A similar problem with UpdateRequestProcessors was noted and fixed in SOLR-13255 but that did not fix the case of Atomic Updates where the field is a Map from operation->value and hence the value was not a String anymore, but a ByteArrayUtf8CharSequence.
mkavanagh
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… format.
This relates to a change in behaviour introduced in SOLR-12983 which affected how javabin encodes strings, they are ByteArrayUtf8CharSequence and not String objects (but both are CharSequence). A similar problem with UpdateRequestProcessors was noted and fixed in SOLR-13255 but that did not fix the case of Atomic Updates where the field is a Map from operation->value and hence the value was not a String anymore, but a ByteArrayUtf8CharSequence.