-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace_axon now allows the axon length and numbr of sections to be set #496
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
It looks like your changes do pass our pycodestyle tests:
Could you fix that so that the tests pass, please? |
@AurelienJaquier Sure, pushed an update. |
Reverted part of the code, to retain default behaviour. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #496 +/- ##
==========================================
+ Coverage 87.36% 87.38% +0.01%
==========================================
Files 50 50
Lines 4346 4351 +5
==========================================
+ Hits 3797 3802 +5
Misses 549 549 ☔ View full report in Codecov by Sentry. |
Thanks @Hjorthmedh for your contribution and your patience |
@AurelienJaquier Thank you! Have a great weekend! |
Some of our group members needs the ability to change the length of the axonal initial segment, and the number of sections in it. This pull request adds this ability by introducing
axon_stump_length
andaxon_stump_nsec
.