feat: add type error if path doesn't start with / #882
Conversation
| @@ -13,8 +13,10 @@ export const Method = t.keyof({ | |||
|
|
|||
| export type Method = t.TypeOf<typeof Method>; | |||
|
|
|||
| export type PathString = `/${string}`; | |||
There was a problem hiding this comment.
I'm torn between whether this counts as a breaking change, or something more akin to "this was always intended and the previous behavior is a bug". I'm curious to hear what others think about this.
There was a problem hiding this comment.
Would an endpoint even work if the path didn't didn't start with a /?
There was a problem hiding this comment.
I can test with superagent and express, but right now am assuming it is sort of undefined behavior and a leading / may be implicitly added
There was a problem hiding this comment.
I suppose viewing that as undefined behavior is an argument against it being a breaking change.
There was a problem hiding this comment.
I'm also not opposed to marking this as a breaking change! I can add that to the commit msg if needed.
|
🎉 This PR is included in version @api-ts/[email protected] 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version @api-ts/[email protected] 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version @api-ts/[email protected] 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version @api-ts/[email protected] 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version @api-ts/[email protected] 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
DX-703