Don't silently drop properties when processing an httpRoute
#762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitgopatmcl
changed the title
httpRoute
bitgopatmcl
force-pushed
the
VL-1836-fix-error-message
branch
from
ae0b7ce
to
addbc6c
Compare
bitgopatmcl
force-pushed
the
VL-1836-fix-error-message
branch
2 times, most recently
from
92d03a1
to
48821de
Compare
ericcrosson-bitgo
previously approved these changes
May 9, 2024
bitgopatmcl
force-pushed
the
VL-1836-fix-error-message
branch
from
48821de
to
bc65c5f
Compare
|
🎉 This PR is included in version @api-ts/[email protected] 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version @api-ts/[email protected] 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version @api-ts/[email protected] 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version @api-ts/[email protected] 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version @api-ts/[email protected] 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where errors are swallowed while processing an
httpRoute. Generally this happens while processing a request type, the error just gets swallowed and therequestproperty is omitted from the resulting schema. This then errors out later on in the section of the codebase that expects a request to be there, causing this hard-to-debug error:With this change, the actual error is passed all the way through, making it much easier to see what went wrong.