Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(openapi-generator): wrap nullable $ref parameters in an 'allOf' array #759

Merged
merged 1 commit into from
May 7, 2024

Conversation

ekorenblum-simtlix
Copy link
Contributor

DX-376

OpenAPI spec doesn't allow $ref properties to have siblings (see here), so they're wrapped in an 'allOf' array

Old behavior

propertyName:
  nullable: true
  $ref: '#/components/schemas/Foo'

New bahavior

propertyName:
  nullable: true
  allOf: 
    - $ref: '#/components/schemas/Foo'

…rray

OpenAPI spec doesn't allow $ref properties to have siblings, so they're wrapped in an 'allOf' array
@ekorenblum-simtlix ekorenblum-simtlix requested a review from a team as a code owner May 7, 2024 16:51
@bitgopatmcl bitgopatmcl merged commit b4d0fec into master May 7, 2024
8 checks passed
@bitgopatmcl bitgopatmcl deleted the DX-376-wrap-ref-in-allOf branch May 7, 2024 17:25
Copy link

github-actions bot commented May 7, 2024

🎉 This PR is included in version @api-ts/[email protected] 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

Copy link

github-actions bot commented Jun 4, 2024

🎉 This PR is included in version @api-ts/[email protected] 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

Copy link

github-actions bot commented Jun 4, 2024

🎉 This PR is included in version @api-ts/[email protected] 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

Copy link

github-actions bot commented Jun 4, 2024

🎉 This PR is included in version @api-ts/[email protected] 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

Copy link

github-actions bot commented Aug 5, 2024

🎉 This PR is included in version @api-ts/[email protected] 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants