Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unused cli flags #730

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

andrew-scott-fischer
Copy link
Contributor

The --internal and --unstable cli flags were never actually used by openapi-generator. This commit removes no functionality of the tool, it only cleans the cli interface.

Ticket: VL-1855

@andrew-scott-fischer andrew-scott-fischer requested a review from a team as a code owner April 1, 2024 22:16
bitgopatmcl
bitgopatmcl previously approved these changes Apr 1, 2024
Copy link
Contributor

@bitgopatmcl bitgopatmcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that the includeInternal flag was in the original v1 of openapi-generator, and then was never implemented for v2.

Removes unused command line flags to enshrine existing behavior

Copy link
Contributor

@bitgopatmcl bitgopatmcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't suggest an edit in that location, but the flag and boolean imports are now unused

The `--internal` and `--unstable` cli flags were never actually used by
openapi-generator. This commit removes no functionality of the tool,
it only cleans the cli interface.

Ticket: VL-1855
@bitgopatmcl bitgopatmcl merged commit 03b6239 into BitGo:master Apr 1, 2024
6 checks passed
@andrew-scott-fischer andrew-scott-fischer deleted the remove-unused-flags branch April 1, 2024 22:27
Copy link

github-actions bot commented Apr 1, 2024

🎉 This PR is included in version @api-ts/[email protected] 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

Copy link

🎉 This PR is included in version @api-ts/[email protected] 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

Copy link

🎉 This PR is included in version @api-ts/[email protected] 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants