Update nix flake impl #725
Conversation
|
No dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No dependency changes detected in pull request |
andrew-scott-fischer
force-pushed
the
update-nix-flake-impl
branch
2 times, most recently
from
541a14c
to
a8f69cb
Compare
.nvmrc
Outdated
There was a problem hiding this comment.
Please remove this file. There's no point having it if we're not using it in .ci, and we shouldn't be, because we want actions/setup-node to use the latest LTSes dynamically
There was a problem hiding this comment.
I felt like this would enable someone who doesn't use nix to contribute, or at least build things locally. It also acts as a short hand to see which version of node nix is installing from the nixpkgs, since that's not outlined in the flake.nix.
Are you sure you prefer it to be removed?
There was a problem hiding this comment.
I felt like this would enable someone who doesn't use nix to contribute, or at least build things locally.
We should be ambivalent to which LTS version of Node.js a contributor uses, so this is not a large factor in my opinion.
It also acts as a short hand to see which version of
nodenix is installing from the nixpkgs, since that's not outlined in theflake.nix.
We can simply run node --version to see what version of node Nix is installing, this isn't worth committing another file to our repository, especially one that is a derivation of other committed files.
Are you sure you prefer it to be removed?
Yes please
Nix is the standard interface through which BitGo configures pre-commit-hooks. Removing the npm based pre-commit hooks is the first stage in replacing them with Nix based hooks.
andrew-scott-fischer
force-pushed
the
update-nix-flake-impl
branch
from
a8f69cb
to
be3dba4
Compare
andrew-scott-fischer
force-pushed
the
update-nix-flake-impl
branch
from
be3dba4
to
301c5a0
Compare
Overhauls the nix flake to no longer use flake-utils , adds pre-commit-hooks, and writes the currently used `node --version` to an `.nvmrc`
Bring all files under `prettier`'s all-seeing eye
andrew-scott-fischer
force-pushed
the
update-nix-flake-impl
branch
from
301c5a0
to
e4531f3
Compare
There was a problem hiding this comment.
Replaces pre-commit and lint-staged with pre-commit-hooks.nix ❄️ 🚀
Thanks @andrew-scott-fischer!
|
🎉 This PR is included in version @api-ts/[email protected] 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version @api-ts/[email protected] 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version @api-ts/[email protected] 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
This commit removes npm based pre-commit hooks in favor of
pre-commit-hooksmanaged by Nix.