Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix local pkg versions #43

Merged
merged 1 commit into from
Apr 13, 2022
Merged

Fix local pkg versions #43

merged 1 commit into from
Apr 13, 2022

Conversation

bitgopatmcl
Copy link
Contributor

multi-semantic-release's readme says to use * as the version field for monorepo packages, but this fails in a strange way. This switches them to 0.0.0-semantically-released as recommended in a Github issue.

See: dhoulb/multi-semantic-release#102

@bitgopatmcl bitgopatmcl requested a review from a team April 13, 2022 13:34
@bitgopatmcl
Copy link
Contributor Author

I tried to open a PR to the branch in #42 but it wasn't working for some reason

@ericcrosson-bitgo
Copy link
Contributor

@bitgopatmcl counter to my message in slack -- we might as well try this again to see exactly how it blew up. I can't find the logs from the last attempt, and this won't make anything worse 🙂 so fire in the hole

ericcrosson-bitgo
ericcrosson-bitgo previously approved these changes Apr 13, 2022
View reviewed changes
Copy link
Contributor

@ericcrosson-bitgo ericcrosson-bitgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe I already tried this but can't find the proof of it! So I expect this to break, in a different spot than it's currently breaking, but not to make anything worse, so let's give it a shot and collect that data

@bitgopatmcl
fix: stop using wildcard versions for monorepo packages
6a1c0ee 
`multi-semantic-release`'s readme says to use `*` as the version field
for monorepo packages, but this fails in a strange way. This switches
them to `0.0.0-semantically-released` as recommended in a Github issue.

See: dhoulb/multi-semantic-release#102
ericcrosson-bitgo
ericcrosson-bitgo approved these changes Apr 13, 2022
View reviewed changes
Copy link
Contributor

@ericcrosson-bitgo ericcrosson-bitgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for rebasing

Not sure what would have happened if we left that last commit from #42 in there but this is certainly cleaner 🚀 what a craftsman!

@ericcrosson-bitgo ericcrosson-bitgo merged commit 822eebd into BitGo:master Apr 13, 2022
@github-actions
Copy link

🎉 This PR is included in version 1.0.0-beta.1 🎉

The release is available on npm package (@beta dist-tag)

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 0.2.0-beta.1 🎉

The release is available on npm package (@beta dist-tag)

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 0.1.1-beta.1 🎉

The release is available on npm package (@beta dist-tag)

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 0.2.0-beta.1 🎉

The release is available on npm package (@beta dist-tag)

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericcrosson-bitgo ericcrosson-bitgo ericcrosson-bitgo approved these changes

Assignees
No one assigned
Labels
released on @beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bitgopatmcl @ericcrosson-bitgo