Merge pull request #735 from bitgopatmcl/make-optionalized-work-like-…

…partial Make undefined behavior of optionalized work like partial
BitGo · Apr 10, 2024 · 9308b94 · 9308b94
2 parents 43f8823 + 2b12d17
commit 9308b94
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/packages/io-ts-http/src/combinators.ts b/packages/io-ts-http/src/combinators.ts
@@ -43,6 +43,10 @@ const partialWithoutUndefined = <P extends t.Props>(
     },
     (a) => {
       const result = partialCodec.encode(a);
+      if (result === undefined) {
+        // `t.partial` will return this when passed `undefined` even though it is not in the type
+        return result;
+      }
       for (const key of Object.keys(result)) {
         if (result[key] === void 0) {
           delete result[key];

diff --git a/packages/io-ts-http/test/combinators.test.ts b/packages/io-ts-http/test/combinators.test.ts
@@ -113,6 +113,12 @@ describe('optionalized', () => {
     assertEncodes(optionalCodec, { a: undefined, b: 'foo' }, expected);
   });
 
+  it('returns undefined when encoding undefined', () => {
+    const optionalCodec = c.optionalized({});
+    const expected = undefined;
+    assertEncodes(optionalCodec, undefined, expected);
+  });
+
   it('decodes explicit null properties', () => {
     const nullCodec = c.optionalized({
       a: t.null,