Pull requests #85
Merged
Pull requests #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…teration and speices columns and removing misleading error message.
… and bootstrap_indicator(), and small changes to functions
This reverts commit b91df5b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @AugustT,
Please review the GHA for this pull request R CMD check here.
Also, I've realised that the check
!requireNamespace("jagsUI", quietly = TRUE))doesn't actually check for the installation of JAGS. Given the jagsUI package is essential for the functions to work, I've moved jagsUI from the suggests to the imports field of the description.We should consider removing
!requireNamespace("jagsUI", quietly = TRUE))as I don't think it is necessary to detect a package that can be installed from CRAN. Instead, I've added tests to search directly for the installation of JAGS, using the testjags function from the runjags package.