Label packages #21
Open
Label packages #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the filter label and operator label packages to the turbo repo. Includes jest testing and correct eslint for both packages
Reran jest Tests to create the new snapshots
|
The component .tsx files themselves seem fine, but we probably want them all in discvr-ui-components rather than each component getting its own package with a separate package.json and a .tsconfig. |
added .idea to the gitignore combined the packages into ui setup the tests and src folders to run with all the scripts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted the Operator-label and field-label into discvr-components. This includes making the jest tests and fixing the code to work with eslint
Finished Issues: #16 and #17