Allow to drag the parent of the selected element #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor the drag menu option to not have singleton data so we can have as many instances of as we want. Instead, the element it will drag is passed in from the outside.
leandrocp
approved these changes
Oct 4, 2024
leandrocp
pushed a commit
that referenced
this pull request
Oct 9, 2024
* Allow to drag the parent of the selected element Refactor the drag menu option to not have singleton data so we can have as many instances of as we want. Instead, the element it will drag is passed in from the outside. * Remove log, position handle better * Highlight the parent of the selected item * Dragging the parent works! * auto format code --------- Co-authored-by: cibernox <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Quite often, elements have wrappers with no padding. When there's no padding, it's not possible to select the wrapper of an element because the click always lands on the children.
Until now, it was possible to click the "Go one level up" button to traverse the tree towards the root, but it was incovenient.
Now, when an element is selected to be dragged, the parent element also shows a handle button to drag it. This makes dragging much more convenient, as there's less steps involved in selecting and dragging the element you intended.
How does it look
parent-dragging-h265.mov