fix(Automattic#288) space already handled with encodeURI, duped calls…

… to encodeSpecialCharacters
BausCode · Aug 10, 2016 · 4dbf1f1 · 4dbf1f1
1 parent 278337d
commit 4dbf1f1
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/lib/client.js b/lib/client.js
@@ -64,7 +64,7 @@ function removeLeadingSlash(filename) {
 function encodeSpecialCharacters(filename) {
  // Note: these characters are valid in URIs, but S3 does not like them for
  // some reason.
- return encodeURI(filename).replace(/[!'()#*+? ]/g, function (char) {
+ return encodeURI(filename).replace(/[!'()#*+?]/g, function (char) {
  return '%' + char.charCodeAt(0).toString(16);
  });
 }
@@ -823,7 +823,7 @@ Client.prototype.list = function(params, headers, fn){
  */
 
 Client.prototype.http = function(filename){
- filename = encodeSpecialCharacters(ensureLeadingSlash(filename));
+ filename = ensureLeadingSlash(filename);
 
  return 'http://' + this.urlBase + filename;
 };
@@ -837,7 +837,7 @@ Client.prototype.http = function(filename){
  */
 
 Client.prototype.https = function(filename){
- filename = encodeSpecialCharacters(ensureLeadingSlash(filename));
+ filename = ensureLeadingSlash(filename);
 
  return 'https://' + this.urlBase + filename;
 };