Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated header function #96

Open
wants to merge 2 commits into
base: single-file
Choose a base branch
from

Conversation

Gamerboy59
Copy link

No description provided.

@Bastian
Copy link
Owner

Bastian commented Dec 30, 2021

Thank you for the PR!

The bStats Metrics classes should remain compatible with older versions of Bukkit and Spigot. The YamlConfigurationOptions#setHeader(...) method does not exist in older versions of Spigot (I checked 1.12.2) and thus this PR breaks compatibility with older Bukkit/Spigot versions. For backward compatibility, we have to use reflection.

@Gamerboy59
Copy link
Author

Gamerboy59 commented Feb 14, 2022

I'm not familiar with reflections but maybe it's working like in the new commit?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants