BungeeCord IP forwarding as 3rd auth setting

[lucyydotp]

Displays servers set up to use BungeeCord's IP forwarding. It uses reflection to avoid creating a dependency on spigot.

Considering that a very large portion of servers listed as offline are running behind a bungee, it makes sense to display them separately.

[Bastian]

Thank you for the PR and sorry for the late response! This is a great addition to make the online mode chart more meaningful.

Do you know how reliable this way of detecting a Bungeecord server is? Does the same method exist on Paper server?
Besides that, it would be better to send this as a new bungeecordEnabled field instead of using a third value for the onlineMode field.

[NoahvdAa]

Paper also has Velocity forwarding, might be a good thing to add aswell

[lucyydotp]

Do you know how reliable this way of detecting a Bungeecord server is? Does the same method exist on Paper server?

It reads directly from the server's configuration object, so it's reliable. I've never seen it break, and paper does everything in its own file instead of messing with this one so it still works.

Besides that, it would be better to send this as a new bungeecordEnabled field instead of using a third value for the onlineMode field.

I disagree here. From a standalone point of view, the server is neither verifying accounts (as per online mode) or generating a UUID based on the username (as per offline mode), instead just doing whatever the proxy sends over. Making it a third value separates genuine offline mode servers from those using bungeecord, making the data recorded more useful.

[lucyydotp]

Paper also has Velocity forwarding, might be a good thing to add aswell

Noted, will look into this.

[Jannyboy11]

Paper has config values for whether BungeeCord and Velocity are in online mode. I use the following check in my own plugin:
https://github.com/Jannyboy11/InvSee-plus-plus/blob/0dc42289f9b6fdf5fa145db8c52d265d3fb53414/InvSee%2B%2B_Common/src/main/java/com/janboerman/invsee/spigot/internal/NamesAndUUIDs.java#L107

Online-mode check:
https://github.com/Jannyboy11/InvSee-plus-plus/blob/0dc42289f9b6fdf5fa145db8c52d265d3fb53414/InvSee%2B%2B_Common/src/main/java/com/janboerman/invsee/spigot/internal/NamesAndUUIDs.java#L152