Feature/PXS-6168 add premium theme #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ycewe
reviewed
Jul 29, 2024
|
|
||
| themes = ThemeService.THEMES; | ||
|
|
||
| onSelect(theme: any) { |
There was a problem hiding this comment.
Maybe theme: ThemeService.THEMES or string?
There was a problem hiding this comment.
Well i set it to as onselect($event) is passed as parameter
i have to add object as well as it was throwing error that $event can be string or object and then checking in the function if it's a string then the logic follows
if(typeof theme === 'string'){
ThemeService.setTheme(theme);
this.theme = theme;
}
}
There was a problem hiding this comment.
Yes, this sounds like a better practice. string or Event type maybe?
apps/golden-sample-app/src/app/theme-switcher/theme-switcher.component.ts
Outdated
Show resolved
Hide resolved
ycewe
reviewed
Jul 30, 2024
apps/golden-sample-app/src/app/theme-switcher/theme-switcher.component.ts
Outdated
Show resolved
Hide resolved
ycewe
approved these changes
Jul 30, 2024
ankypant
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a dropdown to toggle between themes
Screen.Recording.2024-07-26.at.5.55.01.PM.mov