fix: Fixed feature lib for transactions Journey (#220)

.prettierignore

@@ -4,3 +4,5 @@
 /coverage
 messages.xlf
 messages.*.xlf
+
+.angular

libs/transactions-journey/feature-transaction-details-view/.eslintrc.json

@@ -0,0 +1,36 @@
+{
+ "extends": ["../../../.eslintrc.json"],
+ "ignorePatterns": ["!**/*"],
+ "overrides": [
+ {
+ "files": ["*.ts"],
+ "rules": {
+ "@angular-eslint/directive-selector": [
+ "error",
+ {
+ "type": "attribute",
+ "prefix": "bb",
+ "style": "camelCase"
+ }
+ ],
+ "@angular-eslint/component-selector": [
+ "error",
+ {
+ "type": "element",
+ "prefix": "bb",
+ "style": "kebab-case"
+ }
+ ]
+ },
+ "extends": [
+ "plugin:@nx/angular",
+ "plugin:@angular-eslint/template/process-inline-templates"
+ ]
+ },
+ {
+ "files": ["*.html"],
+ "extends": ["plugin:@nx/angular-template"],
+ "rules": {}
+ }
+ ]
+}

libs/transactions-journey/feature-transaction-details-view/README.md

@@ -0,0 +1,7 @@
+# transactions-journey-feature-transaction-details-view
+
+This library was generated with [Nx](https://nx.dev).
+
+## Running unit tests
+
+Run `nx test transactions-journey-feature-transaction-details-view` to execute the unit tests.

libs/transactions-journey/feature-transaction-details-view/jest.config.ts

@@ -0,0 +1,23 @@
+/* eslint-disable */
+export default {
+ displayName: 'transactions-journey-feature-transaction-details-view',
+ preset: '../../../jest.preset.js',
+ setupFilesAfterEnv: ['<rootDir>/src/test-setup.ts'],
+ coverageDirectory:
+ '../../../coverage/libs/transactions-journey/feature-transaction-details-view',
+ transform: {
+ '^.+\\.(ts|mjs|js|html)$': [
+ 'jest-preset-angular',
+ {
+ tsconfig: '<rootDir>/tsconfig.spec.json',
+ stringifyContentPathRegex: '\\.(html|svg)$',
+ },
+ ],
+ },
+ transformIgnorePatterns: ['node_modules/(?!.*\\.mjs$)'],
+ snapshotSerializers: [
+ 'jest-preset-angular/build/serializers/no-ng-attributes',
+ 'jest-preset-angular/build/serializers/ng-snapshot',
+ 'jest-preset-angular/build/serializers/html-comment',
+ ],
+};

libs/transactions-journey/feature-transaction-details-view/project.json

@@ -0,0 +1,34 @@
+{
+ "name": "transactions-journey-feature-transaction-details-view",
+ "$schema": "../../../node_modules/nx/schemas/project-schema.json",
+ "sourceRoot": "libs/transactions-journey/feature-transaction-details-view/src",
+ "prefix": "backbase",
+ "tags": ["scope:transaction-details-view-journey", "type:feature"],
+ "projectType": "library",
+ "targets": {
+ "test": {
+ "executor": "@nx/jest:jest",
+ "outputs": ["{workspaceRoot}/coverage/{projectRoot}"],
+ "options": {
+ "jestConfig": "libs/transactions-journey/feature-transaction-details-view/jest.config.ts",
+ "passWithNoTests": true
+ },
+ "configurations": {
+ "ci": {
+ "ci": true,
+ "codeCoverage": true
+ }
+ }
+ },
+ "lint": {
+ "executor": "@nx/linter:eslint",
+ "outputs": ["{options.outputFile}"],
+ "options": {
+ "lintFilePatterns": [
+ "libs/transactions-journey/feature-transaction-details-view/**/*.ts",
+ "libs/transactions-journey/feature-transaction-details-view/**/*.html"
+ ]
+ }
+ }
+ }
+}

libs/transactions-journey/feature-transaction-details-view/src/index.ts

@@ -0,0 +1 @@
+export { TransactionDetailsComponent } from './lib/transactions-journey-feature-transaction-details-view.component';

libs/transactions-journey/feature/src/lib/components/transaction-details-view/transaction-details-view.component.ts → libs/transactions-journey/feature-transaction-details-view/src/lib/transactions-journey-feature-transaction-details-view.component.ts

@@ -9,7 +9,7 @@ import {
 } from '@backbase/foundation-ang/observability';
 import { combineLatest, map } from 'rxjs';
 import { TransactionsHttpService } from '@backbase-gsa/internal-transactions-data-access';
-import { TransactionDetailsTrackerEvent } from '@backbase/internal-transactions-shared-data';
+import { TransactionDetailsTrackerEvent } from '@backbase-gsa/internal-transactions-shared-data';
 import { ButtonModule } from '@backbase/ui-ang/button';
 import { AmountModule } from '@backbase/ui-ang/amount';
 import { IconModule } from '@backbase/ui-ang/icon';
@@ -31,9 +31,12 @@ interface TransactionDetailsView {
 }
 
 @Component({
- templateUrl: './transaction-details-view.component.html',
+ templateUrl:
+ './transactions-journey-feature-transaction-details-view.component.html',
  selector: 'bb-transaction-details',
- styleUrls: ['./transaction-details-view.component.scss'],
+ styleUrls: [
+ './transactions-journey-feature-transaction-details-view.component.scss',
+ ],
  imports: [
  TrackerModule,
  ButtonModule,

libs/transactions-journey/feature-transaction-details-view/src/test-setup.ts

@@ -0,0 +1,8 @@
+// @ts-expect-error https://thymikee.github.io/jest-preset-angular/docs/getting-started/test-environment
+globalThis.ngJest = {
+ testEnvironmentOptions: {
+ errorOnUnknownElements: true,
+ errorOnUnknownProperties: true,
+ },
+};
+import 'jest-preset-angular/setup-jest';

libs/transactions-journey/feature-transaction-details-view/tsconfig.json

@@ -0,0 +1,29 @@
+{
+ "compilerOptions": {
+ "target": "es2022",
+ "useDefineForClassFields": false,
+ "forceConsistentCasingInFileNames": true,
+ "strict": true,
+ "noImplicitOverride": true,
+ "noPropertyAccessFromIndexSignature": true,
+ "noImplicitReturns": true,
+ "noFallthroughCasesInSwitch": true
+ },
+ "files": [],
+ "include": [],
+ "references": [
+ {
+ "path": "./tsconfig.lib.json"
+ },
+ {
+ "path": "./tsconfig.spec.json"
+ }
+ ],
+ "extends": "../../../tsconfig.base.json",
+ "angularCompilerOptions": {
+ "enableI18nLegacyMessageIdFormat": false,
+ "strictInjectionParameters": true,
+ "strictInputAccessModifiers": true,
+ "strictTemplates": true
+ }
+}

libs/transactions-journey/feature-transaction-details-view/tsconfig.lib.json

@@ -0,0 +1,17 @@
+{
+ "extends": "./tsconfig.json",
+ "compilerOptions": {
+ "outDir": "../../../dist/out-tsc",
+ "declaration": true,
+ "declarationMap": true,
+ "inlineSources": true,
+ "types": []
+ },
+ "exclude": [
+ "src/**/*.spec.ts",
+ "src/test-setup.ts",
+ "jest.config.ts",
+ "src/**/*.test.ts"
+ ],
+ "include": ["src/**/*.ts"]
+}

libs/transactions-journey/feature-transaction-details-view/tsconfig.spec.json

@@ -0,0 +1,16 @@
+{
+ "extends": "./tsconfig.json",
+ "compilerOptions": {
+ "outDir": "../../../dist/out-tsc",
+ "module": "commonjs",
+ "target": "es2016",
+ "types": ["jest", "node"]
+ },
+ "files": ["src/test-setup.ts"],
+ "include": [
+ "jest.config.ts",
+ "src/**/*.test.ts",
+ "src/**/*.spec.ts",
+ "src/**/*.d.ts"
+ ]
+}

libs/transactions-journey/feature/jest.config.ts → libs/transactions-journey/feature-transaction-view/jest.config.ts

@@ -4,7 +4,8 @@ export default {
  preset: '../../../jest.preset.js',
  setupFilesAfterEnv: ['<rootDir>/src/test-setup.ts'],
  globals: {},
- coverageDirectory: '../../../coverage/libs/transactions-journey/feature',
+ coverageDirectory:
+ '../../../coverage/libs/transactions-journey/feature-transaction-view',
  transform: {
  '^.+\\.(ts|mjs|js|html)$': [
  'jest-preset-angular',

libs/transactions-journey/feature-transaction-view/project.json

@@ -0,0 +1,27 @@
+{
+ "name": "transactions-journey-feature-transaction-view",
+ "$schema": "../../../node_modules/nx/schemas/project-schema.json",
+ "projectType": "library",
+ "sourceRoot": "libs/transactions-journey/feature-transaction-view/src",
+ "prefix": "backbase",
+ "targets": {
+ "test": {
+ "executor": "@nx/jest:jest",
+ "outputs": ["{workspaceRoot}/coverage/libs/transactions-journey/feature-transaction-view"],
+ "options": {
+ "jestConfig": "libs/transactions-journey/feature-transaction-view/jest.config.ts",
+ "passWithNoTests": true
+ }
+ },
+ "lint": {
+ "executor": "@nx/linter:eslint",
+ "options": {
+ "lintFilePatterns": [
+ "libs/transactions-journey/feature-transaction-view/**/*.ts",
+ "libs/transactions-journey/feature-transaction-view/**/*.html"
+ ]
+ }
+ }
+ },
+ "tags": ["scope:transactions-journey", "type:feature"]
+}

libs/transactions-journey/feature/src/index.ts → libs/transactions-journey/feature-transaction-view/src/index.ts

@@ -1,6 +1,5 @@
 export { TransactionsViewComponent } from './lib/components/transactions-view/transactions-view.component';
 export { TransactionItemComponent } from './lib/components/transaction-item/transaction-item.component';
-export { TransactionDetailsComponent } from './lib/components/transaction-details-view/transaction-details-view.component';
 export {
  TRANSACTION_EXTENSIONS_CONFIG,
  TransactionsJourneyExtensionsConfig,

libs/transactions-journey/feature/src/lib/components/transactions-view/transactions-view.component.ts → libs/transactions-journey/feature-transaction-view/src/lib/components/transactions-view/transactions-view.component.ts

@@ -15,7 +15,7 @@ import {
  TransactionsHttpService,
 } from '@backbase-gsa/internal-transactions-data-access';
 
-import { TransactionListTrackerEvent } from '@backbase/internal-transactions-shared-data';
+import { TransactionListTrackerEvent } from '@backbase-gsa/internal-transactions-shared-data';
 @Component({
  templateUrl: './transactions-view.component.html',
  styleUrls: ['./transactions-view.component.scss'],

libs/transactions-journey/shared-data/package.json

@@ -1,5 +1,5 @@
 {
- "name": "@backbase/internal-transactions-shared-data",
+ "name": "@backbase-gsa/internal-transactions-shared-data",
  "version": "0.0.1",
  "peerDependencies": {
  "@angular/common": "^16.1.3",

libs/transactions-journey/shell/src/index.ts

@@ -8,7 +8,7 @@ export {
  TransactionsJourneyExtensionsConfig,
  TransactionAdditionalDetailsComponent,
  TransactionAdditionalDetailsContext,
-} from '@backbase-gsa/internal-transactions-feature';
+} from '@backbase-gsa/internal-transactions-feature-transaction-view';
 export {
  TransactionsJourneyConfiguration,
  ArrangementsService,

libs/transactions-journey/shell/src/lib/transactions-journey-shell.module.ts

@@ -12,19 +12,18 @@ import { TrackerModule } from '@backbase/foundation-ang/observability';
 
 import { TextFilterComponent } from '@backbase-gsa/internal-transactions-ui';
 
-import { TRANSLATIONS } from '@backbase/internal-transactions-shared-data';
+import { TRANSLATIONS } from '@backbase-gsa/internal-transactions-shared-data';
 import {
  TransactionsJourneyConfiguration,
  TransactionsRouteTitleResolverService,
 } from '@backbase-gsa/internal-transactions-data-access';
+import { TransactionDetailsComponent } from '@backbase-gsa/internal-transactions-feature-transaction-details-view';
 import {
- TransactionsViewComponent,
- TransactionDetailsComponent,
  TRANSACTION_EXTENSIONS_CONFIG,
  TransactionsJourneyExtensionsConfig,
+ TransactionsViewComponent,
  TransactionsViewModule,
-} from '@backbase-gsa/internal-transactions-feature';
-
+} from '@backbase-gsa/internal-transactions-feature-transaction-view';
 const defaultRoutes: Routes = [
  {
  path: '',