Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Opticks hits code #56

Merged
merged 2 commits into from
Nov 11, 2024
Merged

Added Opticks hits code #56

merged 2 commits into from
Nov 11, 2024

Conversation

ggalgoczi
Copy link
Collaborator

No description provided.

@ggalgoczi ggalgoczi merged commit e42999b into main Nov 11, 2024
2 checks passed
@ggalgoczi ggalgoczi deleted the OpticksHits branch November 11, 2024 23:08
<property name="RINDEX" ref="RINDEX0x560299349730"/>
<property name="GROUPVEL" ref="GROUPVEL0x560299349110"/>
<property name="RINDEX" ref="RINDEX0x5602993a1df1"/>
<property name="GROUPVEL" ref="GROUPVEL0x56029938bb90"/>
Copy link
Member

@plexoos plexoos Nov 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the reason for changing these properties for G4_AIR? Was it needed to see hits?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No hits with Opticks yet. I was experimenting around how to get hits. At this point I am not sure if it is an issue with the GDML or an issue with how we simulate photons.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, just to confirm this change is not relevant for getting G4 hits, correct?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, for G4Hits irrelevant. But we want Optickshits too.

Comment on lines +133 to +134
<property name="RINDEX" ref="RINDEX0x5602993a1df3"/>
<property name="GROUPVEL" ref="GROUPVEL0x56029938bb90"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these new lines needed?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rindex is needed for all materials. I have tried running without refractive index before and there were no hits. I am not sure if GROUPVEL is needed or not, some GDML uses it, some not.

Comment on lines +125 to +126
<property name="RINDEX" ref="RINDEX0x5602993a1df2"/>
<property name="GROUPVEL" ref="GROUPVEL0x56029938bb90"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question. Do we need to define a GROUPVEL property to see hits in this volume?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think they are not a must.

Comment on lines +2 to +4
<gdml_simple_extension xmlns:gdml_simple_extension="http://www.example.org"
xmlns:xs="http://www.w3.org/2001/XMLSchema-instance"
xs:noNamespaceSchemaLocation="SimpleExtension.xsd">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the point of switching to this new tag, gdml_simple_extension?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked in CaTS, copied here. Not sure if has effect.

plexoos added a commit that referenced this pull request Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants