Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Crypto/rsa encrypter #35

Merged
merged 5 commits into from
Jun 3, 2024
Merged

Crypto/rsa encrypter #35

merged 5 commits into from
Jun 3, 2024

Conversation

glacialcascade
Copy link
Contributor

No description provided.

@mud-ali mud-ali added crypto Cryptography challenge needs-review Feel free to review this challenge labels May 2, 2024
@mud-ali
Copy link
Member

mud-ali commented May 2, 2024

Challenge lgtm, however, the solvepath is kind of unclear, either place some comments describing the algorithm and/or linking some references, or put a solve.md file and wrap the code in there and break it down @ZeviCohen

@mud-ali mud-ali added documentation Improvements or additions to documentation files approved Challenge approved changes-requested Make the requested changes to the challenge before merging and removed needs-review Feel free to review this challenge labels May 2, 2024
@Zevirino
Copy link
Contributor

Zevirino commented May 2, 2024

@mud-ali I cleaned up the code a bit so hopefully it is clearer now. I also added a hint. I'm getting merge conflicts so I can't merge pull request rn and I'm not really sure what to do.

@mud-ali
Copy link
Member

mud-ali commented May 2, 2024

@mud-ali I cleaned up the code a bit so hopefully it is clearer now. I also added a hint. I'm getting merge conflicts so I can't merge pull request rn and I'm not really sure what to do.

yeah it looks fine. don't worry about the merge conflicts, I'll figure those out and merge it later

@mud-ali mud-ali removed documentation Improvements or additions to documentation files changes-requested Make the requested changes to the challenge before merging labels May 2, 2024
@mud-ali mud-ali merged commit 0296746 into main Jun 3, 2024
1 check passed
@mud-ali mud-ali deleted the crypto/RSAEncrypter branch June 3, 2024 14:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Challenge approved crypto Cryptography challenge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants