Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

crypto/encryptor-shop #27

Merged
merged 5 commits into from
Jun 7, 2024
Merged

crypto/encryptor-shop #27

merged 5 commits into from
Jun 7, 2024

Conversation

mud-ali
Copy link
Member

@mud-ali mud-ali commented Apr 9, 2024

No description provided.

@mud-ali mud-ali added crypto Cryptography challenge needs-review Feel free to review this challenge labels Apr 9, 2024
@Blckbrry-Pi Blckbrry-Pi requested review from Blckbrry-Pi and removed request for glacialcascade April 10, 2024 13:30
Copy link
Contributor

@Blckbrry-Pi Blckbrry-Pi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Just note those 2 deployment errors, and maybe try building your docker containers before pushing next time. 🙃

Just a note: hints can be an empty array if you want to not annoy the participants. (Like hints: [])

enc-shop/Dockerfile Outdated Show resolved Hide resolved
enc-shop/requirements.txt Outdated Show resolved Hide resolved
@mud-ali mud-ali requested review from glacialcascade and removed request for Blckbrry-Pi June 6, 2024 18:48
@glacialcascade
Copy link
Contributor

I am now realizing that you don't need any of the quadratic-solving things at all.

Since the two n's share a factor, simply compute their gcd. You now have p.

Maybe consider removing phi entirely from the output (or find a way to use this idea in another chall)

@glacialcascade glacialcascade merged commit e05e507 into main Jun 7, 2024
1 check passed
@glacialcascade glacialcascade deleted the crypto/enc-shop branch June 10, 2024 23:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
crypto Cryptography challenge needs-review Feel free to review this challenge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants