Update locking and caching for OpenIdConnectCachingSecurityTokenProvider
#3124
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update locking and caching for
OpenIdConnectCachingSecurityTokenProvider
Update locking and caching for
OpenIdConnectCachingSecurityTokenProvider
Description
This is a proposed alternative to #3118.
Changes:
Interlocked.Exchange
to ensure a single thread callsConfigurationManager.GetConfigurationAsync
at a time.Thanks for offering me to open a PR for this.
Please get as many eyes as you can on this to validate my assumptions. I don't have much confidence in my multi-threading, locking, and synchronization abilities.
Also, feel free to take over that PR to adjust to your coding preferences; one thing I noticed is the code base seems to prefer using
Interlocked.CompareExchange
overInterlocked.Exchange
.Essentially, this is now yours, although I'll definitely keep an eye on it and answer questions where I can.
Fixes #3078