Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unobsolete GetAccountsAsync #4976

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Unobsolete GetAccountsAsync #4976

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2443112
Unobsolete GetAccountsAsync
neha-bhargava Oct 23, 2024
75356ca
Add comment to use GetAccounts only for ROPC
neha-bhargava Oct 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/client/Microsoft.Identity.Client/IConfidentialClientApplication.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,8 +96,6 @@ AcquireTokenByAuthorizationCodeParameterBuilder AcquireTokenByAuthorizationCode(
/// <summary>
/// Use <see cref="IClientApplicationBase.GetAccountAsync(string)"/> in web apps and web APIs, and use a token cache serializer for better security and performance. See https://aka.ms/msal-net-cca-token-cache-serialization.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls add a remark that this is only for use with ROPC

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have no way to enforce that it's only used for ROPC in CCA, though
Are we sure that the cache is always partitioned?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK the cache is always partitioned.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is partitioned. But please add a unit test (or update the integration test) @neha-bhargava, where you show that TokenCacheNotificationArgs has the correct SuggestedCacheKey.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@neha-bhargava and I had a chat and concluded that AcquireTokenForUsernamePassword is partitioned, but GetAccounts() is not partitioned (and can't really be partitioned).

From MSAL perspective, we can ask ppl to use GetAccount(id).
For Id.Web, this gets a bit tricky.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How would that work in MSAL? where do they get the id from? (assuming this is tid.oid?)?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proposing that CCA.AcquireTokenByUserPassword first checks the cache, and if not found or error, goes to ESTS.
Like OBO does.

/// </summary>
[Obsolete("Use GetAccountAsync(identifier) in web apps and web APIs, and use a token cache serializer for better security and performance. See https://aka.ms/msal-net-cca-token-cache-serialization.")]
[EditorBrowsable(EditorBrowsableState.Never)]
new Task<IEnumerable<IAccount>> GetAccountsAsync();
}
}