Expose client capabilities in AssertionRequestOptions for MSI FIC scenarios #4972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neha-bhargava
approved these changes
Oct 22, 2024
trwalke
approved these changes
Oct 24, 2024
bgavrilMS
reviewed
Oct 24, 2024
| /// <summary> | ||
| /// Client Capabilities to be included in the client assertion | ||
| /// </summary> | ||
| public IEnumerable<string> ClientCapabilities { get; set; } |
bgavrilMS
reviewed
Oct 24, 2024
| @@ -1857,6 +1857,7 @@ public void AssertionInputIsMutable() | |||
| options.TokenEndpoint = "https://login.microsoft.com/v2.0/token"; | |||
| options.CancellationToken = CancellationToken.None; | |||
| options.Claims = TestConstants.Claims; | |||
| options.ClientCapabilities = TestConstants.ClientCapabilities; | |||
There was a problem hiding this comment.
A test for this is as follows:
- Create a CCA + WIthClientAssertion(AssertionOptions o => { Assert.AreEquals( "cp1", o.CP})
- Call AcquireToken*.WithCP("cp1");
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4948
Changes proposed in this request
Updated AssertionRequestOptions to handle client capabilities for MSI Federated Identity Credential (FIC) scenarios, ensuring that higher-level SDKs can pass capabilities to MSAL.
Testing
unit tests
Performance impact
n/a
Documentation