Remove restrictions armresourcelist #1674
Conversation
|
All changed packages have been documented.
Show changes
|
|
You can try these changes here
|
AlitzelMendez
requested review from
bterlson,
markcowl,
allenjzhang and
timotheeguerin
as code owners
| @@ -293,7 +293,7 @@ model ResourceKindProperty { | |||
| */ | |||
| @doc("The response of a {name} list operation.", Resource) | |||
| @friendlyName("{name}ListResult", Resource) | |||
| model ResourceListResult<Resource extends Foundations.Resource> is Azure.Core.Page<Resource>; | |||
| model ResourceListResult<Resource extends {}> is Azure.Core.Page<Resource>; | |||
There was a problem hiding this comment.
There is some issue with this. If the intension has been to support scalar or array types, it would not work. Playground. In addition, Azure.Core.Page<T extends Model>, making this would fail in Azure.Core as well.
There was a problem hiding this comment.
{} and Model are equivalent constraints. Also, this handles most list cases. If we want to open up the paged data to be any type (or scalar and model types), we can use our own custom page. Here is a playground showing the definition for ResourceListResult working with Page<T> and a completely custom paged result.
There was a problem hiding this comment.
Mark for this approach, are you thinking on creating a new operation or do we still see this as an update on ArmResourceListByParent operation?
if we update on ArmResourceListByParent, is there a way to do it without being a breaking change?
issue: #262