Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addressing SDK archboard review comments #31191

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Addressing SDK archboard review comments #31191

wants to merge 14 commits into from
+96 −27

Conversation

hamshavathimunibyraiah
Copy link
Member

@hamshavathimunibyraiah hamshavathimunibyraiah commented Oct 23, 2024 •
edited
Loading

Addressing SDK archboard review comments:

  1. Renaming "translate_document" API name to "translate"

  2. Renaming a few models across all langs:

  • StatusSummary => TranslationStatusSummary
  • StorageSource => TranslationStorageSource
  • id to translationId or documentId in appropriate methods
  1. Renamed a few models and methods for Java SDK

@hamshavathimunibyraiah hamshavathimunibyraiah requested a review from a team as a code owner October 23, 2024 21:42
@hamshavathimunibyraiah hamshavathimunibyraiah requested review from vicancy and marclerwick and removed request for a team October 23, 2024 21:42
@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Oct 23, 2024 •
edited
Loading

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This PR has at least one breaking change (label: BreakingChangeReviewRequired).
    To unblock this PR, follow the process at aka.ms/brch.
  • ❌ The required check named Swagger BreakingChange has failed. To unblock this PR, follow the process at aka.ms/brch.

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Oct 23, 2024 •
edited
Loading

Generated ApiView

Language Package Name ApiView Link
Python azure-ai-translation-document https://apiview.dev/Assemblies/Review/53aed6f319854aebbcf0018d59d1c2be?revisionId=11e92eab18f446dab458d71705b0ed59
Swagger Azure.AI.DocumentTranslation https://apiview.dev/Assemblies/Review/7847b18365c8468c8ec154ba6accac82?revisionId=3d501c6d57f745b9a7e1fe1951bcc498
TypeSpec Azure.AI.DocumentTranslation https://apiview.dev/Assemblies/Review/acf80310b66941048f99ebf23977c036?revisionId=ef0e31b1e0a843f1970bc52c4849e70d

@AzureRestAPISpecReview AzureRestAPISpecReview added BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required data-plane TypeSpec Authored with TypeSpec labels Oct 23, 2024
This was referenced Oct 23, 2024
Draft
Draft
Draft
@hamshavathimunibyraiah hamshavathimunibyraiah added the PublishToCustomers Acknowledgement the changes will be published to Azure customers. label Oct 23, 2024
@azure-sdk azure-sdk mentioned this pull request Oct 24, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@catalinaperalta catalinaperalta catalinaperalta left review comments

@vicancy vicancy Awaiting requested review from vicancy vicancy is a code owner automatically assigned from Azure/api-stewardship-board

@marclerwick marclerwick Awaiting requested review from marclerwick marclerwick is a code owner automatically assigned from Azure/api-stewardship-board

@srnagar srnagar Awaiting requested review from srnagar

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required data-plane PublishToCustomers Acknowledgement the changes will be published to Azure customers. TypeSpec Authored with TypeSpec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hamshavathimunibyraiah @catalinaperalta @AzureRestAPISpecReview