-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addressing SDK archboard review comments #31191
Open
hamshavathimunibyraiah
wants to merge
14
commits into
Azure:main
Choose a base branch
from
hamshavathimunibyraiah:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+96
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamshavathimunibyraiah
requested review from
vicancy and
marclerwick
and removed request for
a team
October 23, 2024 21:42
Next Steps to MergeNext steps that must be taken to merge this PR:
|
Generated ApiView
|
AzureRestAPISpecReview
added
BreakingChangeReviewRequired
<valid label in PR review process>add this label when breaking change review is required
data-plane
TypeSpec
Authored with TypeSpec
labels
Oct 23, 2024
This was referenced Oct 23, 2024
hamshavathimunibyraiah
added
the
PublishToCustomers
Acknowledgement the changes will be published to Azure customers.
label
Oct 23, 2024
specification/translation/Azure.AI.DocumentTranslation/models.tsp
Outdated
Show resolved
Hide resolved
specification/translation/Azure.AI.DocumentTranslation/examples/2024-05-01/operations.json
Outdated
Show resolved
Hide resolved
specification/translation/Azure.AI.DocumentTranslation/routes.tsp
Outdated
Show resolved
Hide resolved
specification/translation/Azure.AI.DocumentTranslation/routes.tsp
Outdated
Show resolved
Hide resolved
specification/translation/Azure.AI.DocumentTranslation/client.tsp
Outdated
Show resolved
Hide resolved
specification/translation/Azure.AI.DocumentTranslation/models.tsp
Outdated
Show resolved
Hide resolved
...ure.AI.DocumentTranslation/examples/2023-11-01-preview/DocumentTranslate_MaximumSet_Gen.json
Outdated
Show resolved
Hide resolved
specification/translation/Azure.AI.DocumentTranslation/routes.tsp
Outdated
Show resolved
Hide resolved
…o string type for id
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
BreakingChangeReviewRequired
<valid label in PR review process>add this label when breaking change review is required
data-plane
PublishToCustomers
Acknowledgement the changes will be published to Azure customers.
TypeSpec
Authored with TypeSpec
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing SDK archboard review comments:
Renaming "translate_document" API name to "translate"
Renaming a few models across all langs: