Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return metadata provider task whether it is successful or not #10598

Merged
merged 3 commits into from
Nov 6, 2024

Conversation

liliankasem
Copy link
Member

@liliankasem liliankasem commented Nov 4, 2024

Pull request checklist

IMPORTANT: Currently, changes must be backported to the in-proc branch to be included in Core Tools and non-Flex deployments.

  • Backporting to the in-proc branch is not required
    • Otherwise: Link to backporting PR
  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • My changes do not require diagnostic events changes
    • Otherwise: I have added/updated all related diagnostic events and their documentation (Documentation issue linked to PR)
  • I have added all required tests (Unit tests, E2E tests)

Additional information

With the current behaviour, even if the getFunctionMetadataFromProviderTask completes before the timeout period, we get a timeout exception if it is not successful. This is a bug and ignores potential failures from the task.

@liliankasem liliankasem merged commit 74e3ca7 into dev Nov 6, 2024
9 of 11 checks passed
@liliankasem liliankasem deleted the liliankasem/funcmetadata/return-task branch November 6, 2024 17:35
@liliankasem
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants