Fix custom connection name not working when using IDurableClientFactory -> CreateClient().

[hctan]

Fix custom connection name not working when using IDurableClientFactory -> CreateClient(). It always return the default durable client.

The issue was caused by checking for StorageConnectionString which is no longer assigned any value (checkout the GetAzureStorageOrchestrationServiceSettings() function where the setting object is configured).

The fix is to check connection string in StorageAccountDetails -> ConnectionString instead.

Issue describing the changes in this PR

resolves #issue_for_this_pr

Pull request checklist

• My changes do not require documentation changes
  • Otherwise: Documentation PR is ready to merge and referenced in pending_docs.md
• My changes should not be added to the release notes for the next release
  • Otherwise: I've added my notes to release_notes.md
• My changes do not need to be backported to a previous version
  • Otherwise: Backport tracked by issue/PR #issue_or_pr
• I have added all required tests (Unit tests, E2E tests)
• My changes do not require any extra work to be leveraged by OutOfProc SDKs
  • Otherwise: That work is being tracked here: #issue_or_pr_in_each_sdk
• My changes do not change the version of the WebJobs.Extensions.DurableTask package
  • Otherwise: major or minor version updates are reflected in /src/Worker.Extensions.DurableTask/AssemblyInfo.cs
• My changes do not add EventIds to our EventSource logs
  • Otherwise: Ensure the EventIds are within the supported range in our existing Windows infrastructure. You may validate this with a deployed app's telemetry. You may also extend the range by completing a PR such as this one.
• My changes should be added to v3.x branch.
  • Otherwise: This change only applies to Durable Functions v2.x and will not be merged to branch v3.x.

[cgillum]

Thanks @hctan for this contribution, and for adding tests!

@bachuv and/or @wsugarman, would you be able to take a quick look at this small PR? It seems like an important issue to fix.

[hctan]

Hi @cgillum , is the PR good to merge? I'm checking on my side for the CLA options. I noticed there's a smoke test failing, but I don't think its related to my change, I wasn't able to restart the test.

[cgillum]

Hi @hctan. I'll take a look at the smoke test. If there's no issue, I'll go ahead and merge this.

[cgillum]

I think the MSSQL smoke test failure is probably not related to your change (it may be some external change). If you're able to do the CLA step, then I may just go ahead and merge this.

[hctan]

@microsoft-github-policy-service agree

[hctan]

Hi @cgillum , sorry for the delay. I've done the CLA step. May I know roughly when this change would be in a release after you have merged it? Thanks.

[hctan]

hi @cgillum , can help to approve this? Thanks.

[cgillum]

Thanks again for this PR, and for signing the CLA. I see that the MSSQL smoke test is failing, but I see that it's failing for other PRs as well, hence is not likely related to this change.