Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BugFix-FunctionMetadataProvider emits incorrect binding name property value for async functions #1851

Merged
merged 2 commits into from
Aug 23, 2023
Merged

BugFix-FunctionMetadataProvider emits incorrect binding name property value for async functions #1851

merged 2 commits into from
Aug 23, 2023

Conversation

kshyju
Copy link
Member

@kshyju kshyju commented Aug 22, 2023

Fixes #1817

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

@kshyju kshyju force-pushed the shkr/1817_async_function_incorrect_binding branch from c944a44 to 59c206e Compare August 23, 2023 13:11
@kshyju kshyju merged commit 9917849 into main Aug 23, 2023
25 checks passed
@kshyju kshyju deleted the shkr/1817_async_function_incorrect_binding branch August 23, 2023 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@satvu satvu satvu approved these changes

@liliankasem liliankasem liliankasem approved these changes

@jviau jviau Awaiting requested review from jviau

@brettsam brettsam Awaiting requested review from brettsam

@fabiocav fabiocav Awaiting requested review from fabiocav

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FunctionMetadataProvider emits incorrect binding name property value for async functions
3 participants
@kshyju @liliankasem @satvu