-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
App builder extension method to register extension options #1843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jviau
reviewed
Aug 17, 2023
...ons/Worker.Extensions.CosmosDB/src/Extensions/FunctionsWorkerApplicationBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
...ons/Worker.Extensions.CosmosDB/src/Extensions/FunctionsWorkerApplicationBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
liliankasem
changed the title
Extension method to register extension options for FSharp projects
Extension method to register extension options
Aug 17, 2023
liliankasem
commented
Aug 17, 2023
liliankasem
force-pushed
the
liliankasem/funcbuilderexts
branch
from
August 18, 2023 19:17
86a0451
to
72ce65b
Compare
@mattchenderson we will need to update the docs to make sure folks are aware that if they use Cosmos, Tables or Blob extensions, they will need to register via the ext method: module Program
open Microsoft.Extensions.Hosting
open Microsoft.Azure.Functions.Worker
module Program =
[<EntryPoint>]
let main _ =
let hostBuilder = new HostBuilder()
// FSharp applications need to configure the Cosmos, Blob and/or Table extensions manually.
hostBuilder.ConfigureFunctionsWorkerDefaults(fun (context: HostBuilderContext) (appBuilder: IFunctionsWorkerApplicationBuilder) ->
appBuilder.ConfigureCosmosDB() |> ignore
appBuilder.ConfigureBlobStorage() |> ignore
appBuilder.ConfigureTables() |> ignore
) |> ignore
let host = hostBuilder.Build()
host.Run()
0 Probably calls for a templates update as well |
jviau
requested changes
Aug 21, 2023
extensions/Worker.Extensions.CosmosDB/src/Config/CosmosDBBindingOptionsSetup.cs
Outdated
Show resolved
Hide resolved
jviau
reviewed
Aug 22, 2023
extensions/Worker.Extensions.CosmosDB/src/Config/CosmosDBBindingOptionsSetup.cs
Outdated
Show resolved
Hide resolved
extensions/Worker.Extensions.CosmosDB/src/Config/CosmosDBBindingOptionsSetup.cs
Outdated
Show resolved
Hide resolved
…ngOptionsSetup.cs Co-authored-by: Jacob Viau <[email protected]>
jviau
approved these changes
Aug 28, 2023
liliankasem
changed the title
Extension method to register extension options
App builder extension method to register extension options
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
Related issue: #1826
Pull request checklist
release_notes.md