-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: uncommenting item that reflects on the document links problem #658
base: main
Are you sure you want to change the base?
Conversation
I believe the issue in item Azure#607 will be resolved with this commit.
Hi @waelkdouh, how are you? Just like in my first comment on this pull request, I believe I have found the problem that is breaking the documentation links, and for that I originally created this pull request. Today I updated the packages that need updating, and I have combined them in this same pull request. If I think this could negatively affect the repository, I can cancel this request and create two separate ones. I await your contact, thank you |
Hi @felipementel could you elaborate a bit more on what you mean by it could pretend it could negatively affect this repository? I'm just trying to understand why you are suggesting creating two separate requests. |
@waelkdouh There is a request for a documentation update, which refers to the problem unfortunately, due to a "mistake" of mine, I combined everything in the same PR |
Gotcha. No worries I will review and report back here accordingly. Thanks again for your contributions. |
I believe the issue in item #607 will be resolved with this commit.