-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CTERA Solution for Azure Sentinel #11169
Conversation
@v-prasadboke @v-atulyadav What is the ETA for the code to be reviewed? |
Hello @roberteliass, I'm on leave till 6th Oct. Will get back to you by 9th Oct |
Hello @roberteliass, Please add workbook metadata to the workbooksmetadata file Please try to resolve branch conflicts. |
Hi,
Why this conflict is presented after the commit?
Also it's not inline with what I see on the pull request.
I see a conflict on this file .script/tests/detectionTemplateSchemaValidation/ValidConnectorIds.json
Lines - 252-258
<<<<<<< master
"CTERA"
]
=======
"IllumioSaaSDataConnector"
]
>>>>>> master
If I resolve the conflict like I already did in the past it will go through the entire validation process again without ever getting to the code review.
Can you please clarify the process of getting the pull request approved?
Thanks,
Robert Elias
Product Manager
e. ***@***.******@***.***>
linkedin eliasrobert<http://www.linkedin.com/in/eliasrobert>
***@***.***
From: v-prasadboke ***@***.***>
Sent: October 8, 2024 11:36 AM
To: Azure/Azure-Sentinel ***@***.***>
Cc: Robert Elias ***@***.***>; Mention ***@***.***>
Subject: Re: [Azure/Azure-Sentinel] CTERA Solution for Azure Sentinel (PR #11169)
Hello @roberteliass<https://github.com/roberteliass>, Please add workbook metadata to the workbooksmetadata file
https://github.com/Azure/Azure-Sentinel/blob/master/Workbooks/WorkbooksMetadata.json
Please try to resolve branch conflicts.
-
Reply to this email directly, view it on GitHub<#11169 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A44VKL6XF2FW2H6IUCVADMDZ2OKOXAVCNFSM6AAAAABOVZ3OSGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJZGIYTENRVGE>.
You are receiving this because you were mentioned.Message ID: ***@***.******@***.***>>
|
# Conflicts: # .script/tests/detectionTemplateSchemaValidation/ValidConnectorIds.json
Hi,
I've updated the workbooksmetadata file and resolved the conflicts.
Please help promoting the pull request to be review and if no issues approved.
Thanks,
Robert Elias
Product Manager
e. ***@***.******@***.***>
linkedin eliasrobert<http://www.linkedin.com/in/eliasrobert>
***@***.***
From: v-prasadboke ***@***.***>
Sent: October 8, 2024 11:36 AM
To: Azure/Azure-Sentinel ***@***.***>
Cc: Robert Elias ***@***.***>; Mention ***@***.***>
Subject: Re: [Azure/Azure-Sentinel] CTERA Solution for Azure Sentinel (PR #11169)
Hello @roberteliass<https://github.com/roberteliass>, Please add workbook metadata to the workbooksmetadata file
https://github.com/Azure/Azure-Sentinel/blob/master/Workbooks/WorkbooksMetadata.json
Please try to resolve branch conflicts.
-
Reply to this email directly, view it on GitHub<#11169 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A44VKL6XF2FW2H6IUCVADMDZ2OKOXAVCNFSM6AAAAABOVZ3OSGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJZGIYTENRVGE>.
You are receiving this because you were mentioned.Message ID: ***@***.******@***.***>>
|
Hi again,
Can you please help moving forward with the approval of the pull request, I am in a loop here.
I am pushing the pull request, then after the initial validation process, I usually wait for about a week before the arm-ttk runs (seems like someone is running it manually).
Then I wait for approval and in the meantime, I get a conflict message that I need to resolve, which is just another solution that was added before me.
Can you help me approving the solution promptly to avoid it.
Thanks,
Robert Elias
Product Manager
e. ***@***.******@***.***>
linkedin eliasrobert<http://www.linkedin.com/in/eliasrobert>
***@***.***
From: Robert Elias ***@***.***>
Sent: October 9, 2024 1:07 AM
To: Azure/Azure-Sentinel ***@***.***>; Azure/Azure-Sentinel ***@***.***>
Cc: Mention ***@***.***>
Subject: RE: [Azure/Azure-Sentinel] CTERA Solution for Azure Sentinel (PR #11169)
Hi,
I've updated the workbooksmetadata file and resolved the conflicts.
Please help promoting the pull request to be review and if no issues approved.
Thanks,
Robert Elias
Product Manager
e. ***@***.******@***.***>
linkedin eliasrobert<http://www.linkedin.com/in/eliasrobert>
***@***.***
From: v-prasadboke ***@***.******@***.***>>
Sent: October 8, 2024 11:36 AM
To: Azure/Azure-Sentinel ***@***.******@***.***>>
Cc: Robert Elias ***@***.******@***.***>>; Mention ***@***.******@***.***>>
Subject: Re: [Azure/Azure-Sentinel] CTERA Solution for Azure Sentinel (PR #11169)
Hello @roberteliass<https://github.com/roberteliass>, Please add workbook metadata to the workbooksmetadata file
https://github.com/Azure/Azure-Sentinel/blob/master/Workbooks/WorkbooksMetadata.json
Please try to resolve branch conflicts.
-
Reply to this email directly, view it on GitHub<#11169 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A44VKL6XF2FW2H6IUCVADMDZ2OKOXAVCNFSM6AAAAABOVZ3OSGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJZGIYTENRVGE>.
You are receiving this because you were mentioned.Message ID: ***@***.******@***.***>>
|
Hello @roberteliass, Can you provide me write access to your branch |
Hi,
You already had write access, I revoked and invited you again as a collaborator.
Thanks,
Robert Elias
Product Manager
e. ***@***.******@***.***>
linkedin eliasrobert<http://www.linkedin.com/in/eliasrobert>
***@***.***
From: v-prasadboke ***@***.***>
Sent: October 16, 2024 5:25 PM
To: Azure/Azure-Sentinel ***@***.***>
Cc: Robert Elias ***@***.***>; Mention ***@***.***>
Subject: Re: [Azure/Azure-Sentinel] CTERA Solution for Azure Sentinel (PR #11169)
Hello @roberteliass<https://github.com/roberteliass>, Can you provide me write access to your branch
-
Reply to this email directly, view it on GitHub<#11169 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A44VKL3RFDIYYUUDAKH36W3Z3ZZLRAVCNFSM6AAAAABOVZ3OSGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMJXGAYDAMRXGU>.
You are receiving this because you were mentioned.Message ID: ***@***.******@***.***>>
|
Required items, please complete
Change(s):
Updated files:
Reason for Change(s):
Version Updated:
Testing Completed:
Checked that the validations are passing and have addressed any issues that are present:
- Yes, validation checks were run, and all identified issues were addressed.