Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a Preflight Endpoint for ARO HCP #85

Merged
merged 4 commits into from
Apr 30, 2024
Merged

Conversation

mbarnes
Copy link
Collaborator

@mbarnes mbarnes commented Apr 30, 2024

What this PR does

Before this PR:

No preflight endpoint. ☹️

After this PR:

Preflight endpoint! 😄

Jira: ARO-6156 : Create a Preflight Endpoint for ARO HCP
Link to demo recording:

Special notes for your reviewer

RP contract documentation: What is Preflight?

Per acceptance criteria, this just performs static validation and does not call out to Cluster Service.

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

  • PR: The PR description is expressive enough and will help future contributors
  • Code: Write code that humans can understand and Keep it simple
  • Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
  • Upgrade: Impact of this change on upgrade flows was considered and addressed if required
  • Deployment: The deployment process was considered and addressed if required
  • Testing: New code requires new unit tests.
  • Documentation: Is the documentation updated? Either in the doc located in focus area, in the README or in the code itself.
  • Customers: Is this change affecting customers? Is the release plan considered?

Copy link
Contributor

@mjlshen mjlshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the links to ARM preflight documentation as well!

@mbarnes mbarnes merged commit 8553a2f into Azure:main Apr 30, 2024
3 checks passed
@mbarnes mbarnes deleted the preflight branch April 30, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants