-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix /frontend container build issues #80
Conversation
Signed-off-by: Michael Shen <[email protected]>
Signed-off-by: Michael Shen <[email protected]>
d0b0df4
to
60e5c20
Compare
@@ -38,7 +38,7 @@ brew install colima | |||
|
|||
Before running your devcontainer, make sure colima is started. | |||
```bash | |||
colima start | |||
colima start --cpu 4 --memory 8 --vz-rosetta --vm-type=vz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fyi @s-amann this alone should largely remediate macOS build issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 thank you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if anyone had already ran colima start
you may need to run colima stop; colima delete
before attempting to run with these new vm options
FROM registry.access.redhat.com/ubi8/ubi-minimal:8.9-1161 AS builder | ||
RUN microdnf install -y tar make git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Notably switched the builder container to ubi-minimal as well and am installing git into the builder container
* replace statements are needed to import /internal * store the commit hash via runtime/debug.buildInfo instead of ldflags * describe the required colima configuration for macOS Signed-off-by: Michael Shen <[email protected]>
60e5c20
to
50eacd9
Compare
|
||
clean: | ||
rm --force aro-hcp-frontend |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The --force
flag doesn't exist on macOS (by default anyway...)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requested one change since we're doing away with versions.
Requested change has been addressed. Need to take a closer look at the rest.
There were specific issues building the /frontend container when using colima on macOS that this PR fixes with documentation. However, /frontend was also failing to build due to go module/workspace issues the dependabot is also running into: https://github.com/Azure/ARO-HCP/security/dependabot/6. This PR fixes our build issues and also shifts to
runtime/debug.buildInfo
so that we don't need to leverage a build-time ldflagVersion
variable anymore.What this PR does
e.g. Sample current output: