Fix /frontend container build issues #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Shen <[email protected]>
Signed-off-by: Michael Shen <[email protected]>
mjlshen
requested review from
petrkotas,
s-amann,
mbarnes,
AldoFusterTurpin,
bennerv,
UlrichSchlueter and
jharrington22
as code owners
mjlshen
force-pushed
the
frontend-version
branch
from
d0b0df4
to
60e5c20
Compare
mjlshen
commented
Apr 29, 2024
| @@ -38,7 +38,7 @@ brew install colima | |||
|
|
|||
| Before running your devcontainer, make sure colima is started. | |||
| ```bash | |||
| colima start | |||
| colima start --cpu 4 --memory 8 --vz-rosetta --vm-type=vz | |||
There was a problem hiding this comment.
fyi @s-amann this alone should largely remediate macOS build issues.
There was a problem hiding this comment.
if anyone had already ran colima start you may need to run colima stop; colima delete before attempting to run with these new vm options
mjlshen
commented
Apr 29, 2024
Comment on lines
+2
to
+3
| FROM registry.access.redhat.com/ubi8/ubi-minimal:8.9-1161 AS builder | ||
| RUN microdnf install -y tar make git |
There was a problem hiding this comment.
Notably switched the builder container to ubi-minimal as well and am installing git into the builder container
* replace statements are needed to import /internal * store the commit hash via runtime/debug.buildInfo instead of ldflags * describe the required colima configuration for macOS Signed-off-by: Michael Shen <[email protected]>
mjlshen
force-pushed
the
frontend-version
branch
from
60e5c20
to
50eacd9
Compare
mjlshen
commented
Apr 29, 2024
|
|
||
| clean: | ||
| rm --force aro-hcp-frontend |
There was a problem hiding this comment.
The --force flag doesn't exist on macOS (by default anyway...)
mbarnes
previously requested changes
Apr 29, 2024
mbarnes
dismissed
their stale review
Requested change has been addressed. Need to take a closer look at the rest.
s-amann
approved these changes
Apr 30, 2024
s-amann
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were specific issues building the /frontend container when using colima on macOS that this PR fixes with documentation. However, /frontend was also failing to build due to go module/workspace issues the dependabot is also running into: https://github.com/Azure/ARO-HCP/security/dependabot/6. This PR fixes our build issues and also shifts to
runtime/debug.buildInfoso that we don't need to leverage a build-time ldflagVersionvariable anymore.What this PR does
e.g. Sample current output: