add unit tests for MiddlewareLoggingPostMux function #79
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Before this PR:
We were already generating the appropriate RequestID in the middleware and passing the correlation data to the context, but with a minor error in the setting of the "resource_id" log attribute in MiddlewareLoggingPostMux()(frontend/middleware_logging.go). We were also missing unit tests for the functionality.
After this PR:
We have unit tests for the functionality and we have fixed the minor "resource_id" log attribute error.
Jira
Special notes for your reviewer
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.