database: Store all Operations items in a single partition #730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The azcosmos SDK currently only supports single-partition queries, so there's no way to list all items in a container unless you know all the partition keys. The backend needs to list all items in the Operations container so to work around this limitation we keep all items in a single partition with a well-known name: "workaround". Once [1] is fixed we could transition the Operations container to using subscription IDs as the partition key like other containers. The items are transient thanks to the container's default TTL, so GetOperationDoc would just need temporary fallback logic to check the "workaround" partition. [1] Azure/azure-sdk-for-go#18578
mbarnes
requested review from
bennerv,
mjlshen,
geoberle,
janboll,
jmelis,
jonathan34c,
niontive,
nwnt,
UlrichSchlueter,
weinong and
whober0521
as code owners
mjlshen
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
The azcosmos SDK currently only supports single-partition queries, so there's no way to list all items in a container unless you know all the partition keys. The backend needs to list all items in the Operations container so to work around this limitation we keep all items in a single partition with a well-known name: "workaround".
Once this SDK issue is fixed we could transition the Operations container to using subscription IDs as the partition key like other containers. The items are transient thanks to the container's default TTL, so
GetOperationDocwould just need temporary fallback logic to check the "workaround" partition.Jira: Blocking progress on ARO-8598 - Prototype async op status notification mechanism for RP
Link to demo recording:
Special notes for your reviewer