Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontend: Log error when recovering from a panic #56

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

mbarnes
Copy link
Collaborator

@mbarnes mbarnes commented Apr 16, 2024

Completes MiddlewarePanic, which was written before structured logging was added.

Completes MiddlewarePanic, which was written before structured
logging was added.
Copy link
Contributor

@bennerv bennerv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm; logger is set on new frontend so should always log

@bennerv bennerv merged commit 7d6dd5c into Azure:main Apr 16, 2024
4 checks passed
@mbarnes mbarnes deleted the middleware-panic-log-error branch April 16, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants