Add Key Vault Secrets Officer to Cluster Service MSI #550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janboll
requested review from
bennerv,
geoberle,
jmelis,
jonathan34c,
mjlshen,
niontive,
nwnt,
UlrichSchlueter,
weinong and
whober0521
as code owners
janboll
force-pushed
the
add-cs-cert-officer
branch
from
24900e4
to
d9b4099
Compare
JameelB
reviewed
Sep 3, 2024
| @@ -267,6 +267,19 @@ module csServiceKeyVaultAccess '../modules/keyvault/keyvault-secret-access.bicep | |||
| ] | |||
| } | |||
|
|
|||
| module csServiceKeyVaultCertAccess '../modules/keyvault/keyvault-secret-access.bicep' = { | |||
| name: guid(serviceKeyVaultName, 'cs', 'cert', 'read') | |||
There was a problem hiding this comment.
what difference does the cert make here in comparison to the above? is this just a unique id? Cause the configuration is exactly the same as csServiceKeyVaultAccess which was added in #300
|
looks like not needed after all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Jira:
Link to demo recording:
Special notes for your reviewer