Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing base DNS zone #543

Closed
wants to merge 2 commits into from
Closed

Add missing base DNS zone #543

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b189ab1
Add missing base DNS zone
janboll Aug 29, 2024
74b6928
Fix format
janboll Aug 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions dev-infrastructure/templates/region.bicep
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This global base DNS zone was managed outside of bicep (Ev2 in higher environments, so we created it separately in dev to mimick that). Do you know if something has changed?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's missing for cs integration environment

Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,13 @@ resource subscriptionTags 'Microsoft.Resources/tags@2024-03-01' = {
// R E G I O N A L D N S Z O N E
//


resource baseDNSZone 'Microsoft.Network/dnsZones@2018-05-01' = {
name: '${baseDNSZoneName}'
location: 'global'
}


resource regionalZone 'Microsoft.Network/dnsZones@2018-05-01' = {
name: '${regionalDNSSubdomain}.${baseDNSZoneName}'
location: 'global'
Expand Down
Loading