First pass at enforcing "required" fields in PUT requests #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbarnes
requested review from
petrkotas,
s-amann,
bennerv,
mjlshen,
UlrichSchlueter and
jharrington22
as code owners
added 4 commits
April 9, 2024 15:36
In validation error details, check specifically for an "enum_" prefix on the tag name instead of assuming "anyof" is an enum alias. Just to be more precise to avoid potential future bugs.
Reorder and add parameter for HTTP method.
An updating PUT request must be a complete resource specification. The old version of the resource only comes into play when applying idempotency to read-only or create-only fields in an update request, but this has not yet been implemented.
mbarnes
force-pushed
the
required-for-put
branch
from
8644b0b
to
4f3d40b
Compare
s-amann
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Before this PR:
Required fields from the OpenAPI spec for HCP clusters were not enforced in PUT requests.
After this PR:
Introduces a new validation struct tag
required_for_putand ensures these fields are "non-zero" in PUT requests, both when creating and updating a cluster. Also updates validation error details in HTTP responses to explain missing required fields.Jira: partially completes ARO-6347
Special notes for your reviewer
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.