Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenAPI Spec Linting #25

Merged
merged 1 commit into from
Apr 9, 2024
Merged

OpenAPI Spec Linting #25

merged 1 commit into from
Apr 9, 2024

Conversation

katherinelc321
Copy link
Collaborator

Adds github action to check for uncommitted changes for api
Jira: https://issues.redhat.com/browse/ARO-6276

Copy link
Member

@petrkotas petrkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @katherinelc321 thank you for this PR, it will come in hand and improve the current situation. I have one humble ask, other than that we can get it in.

package.json Outdated Show resolved Hide resolved
@katherinelc321
Copy link
Collaborator Author

/retest

@mjlshen
Copy link
Contributor

mjlshen commented Apr 8, 2024

Ah /retest doesn't work, I think you should rebase to pull in your latest changes

.github/workflows/api-lint.yml Outdated Show resolved Hide resolved
.github/workflows/api-lint.yml Outdated Show resolved Hide resolved
@katherinelc321 katherinelc321 force-pushed the ARO-6276 branch 2 times, most recently from 5748627 to 8b4f353 Compare April 8, 2024 14:50
@mjlshen
Copy link
Contributor

mjlshen commented Apr 9, 2024

Should be good now with one more rebase

Copy link
Contributor

@mjlshen mjlshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@mjlshen mjlshen merged commit 71b9c7a into Azure:main Apr 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants