Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AKS manifest placement #121

Merged
merged 1 commit into from
May 13, 2024
Merged

AKS manifest placement #121

merged 1 commit into from
May 13, 2024

Conversation

geoberle
Copy link
Collaborator

@geoberle geoberle commented May 13, 2024

add a module aks-manifest.bicep to manage resources on AKS clusters. this can be used to

  • create expected Namespaces
  • create exüected ServiceAccounts with MIWI annotations for cloud resource access via Entra
  • create expected ConfigMaps and Secrets holding configuration information for cloud resources, e.g. DB hostnames, ...

An example usage can be seen in the aks-cluster-base.bicep template, where the namespace and serviceaccount are created for each federated managed identity.

The current way to apply the manifests relies on a network path to the cluster. For private clusters we have the following options:

  • use az aks command invoke - experiments resulted in MissingAADClusterToken when run within a deploymentscript
  • run the container instance of the deploymentscript within a VNET that has a network path to the cluster

part of SD-DDR-0030 and https://issues.redhat.com/browse/ARO-7249

What this PR does

Before this PR:

After this PR:

Jira:
Link to demo recording:

Special notes for your reviewer

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

  • PR: The PR description is expressive enough and will help future contributors
  • Code: Write code that humans can understand and Keep it simple
  • Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
  • Upgrade: Impact of this change on upgrade flows was considered and addressed if required
  • Deployment: The deployment process was considered and addressed if required
  • Testing: New code requires new unit tests.
  • Documentation: Is the documentation updated? Either in the doc located in focus area, in the README or in the code itself.
  • Customers: Is this change affecting customers? Is the release plan considered?

@geoberle geoberle marked this pull request as ready for review May 13, 2024 09:21
add a module aks-manifest.bicep to manage resources on AKS clusters.
this can be used to

* create expected `Namespaces`
* create exüected `ServiceAccounts` with MIWI annotations for cloud resource
  access via Entra
* create expected `ConfigMaps` and `Secrets` holding configuration information
  for cloud resources, e.g. DB hostnames, ...

An example usage can be seen in the aks-cluster-base.bicep template,
where the namespace and serviceaccount are created for each federated
managed identity.

part of
[SD-DDR-0030](https://docs.google.com/document/d/1sxnNGscIuEaLRjbILlQrb3sepa4ZVddvj1-COHwQvSQ/edit#heading=h.bupciudrwmna)

Signed-off-by: Gerd Oberlechner <[email protected]>
@mjlshen mjlshen merged commit 0143b87 into Azure:main May 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants