Minor improvements to WooPay test coverage #9671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +27.3 kB (+2%) Total Size: 1.35 MB
ℹ️ View Unchanged
|
|
📦 Build artifact ID: |
|
📦 Build artifact ID: 2159309758 |
malithsen
requested review from
a team and
hsingyuc
and removed request for
a team
malithsen
changed the title
hsingyuc
reviewed
Nov 12, 2024
There was a problem hiding this comment.
Good work, @malithsen! 👍
Should we also make sure classic checkout also renders the form only once?
it( 'should render the save user form when checkbox is checked for classic checkout', () => {
expect( screen.getAllByTestId( 'save-user-form' ) ).toHaveLength( 1 );
} );
| let wasWooPayEnabled: boolean; | ||
|
|
||
| test.beforeAll( async ( { browser } ) => { | ||
| shopperPage = ( await getShopper( browser ) ).shopperPage; |
There was a problem hiding this comment.
Good catch. Removed in 9e8355e
@hsingyuc We already check for it Classic checkout: Blocks checkout: |
hsingyuc
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #9591
This PR introduces a couple of minor improvements to WooPay automated tests.
Changes proposed in this Pull Request
Testing instructions
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge