Ensure highlight colors on the Payments Overview screen use custom admin theme colors #9641
+29
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +119 B (0%) Total Size: 1.35 MB
ℹ️ View Unchanged
|
…ithout rgb var available
brucealdridge
approved these changes
Oct 30, 2024
There was a problem hiding this comment.
I've checked through various screens with various themes. Visually everything looks good. I wonder if it is worth getting @rogermattic to quickly review
|
@brucealdridge thanks for pinging me here!
That sounds right—the color was designed to be an explanatory element in the tooltip, using a custom shade from the Woo Palette (not an accent color) since it’s not a link. The idea was to keep it blue regardless of accent colors, but I get why that’s confusing—it does look similar to the original Gutenberg blue, so I see where this idea of adapting to the theme color comes from. So, sorry for backtracking a bit, but as much as I can see we should probably revisit the colour choice (so that it's from the Gutenberg library), but being a different kind of element (not interactive) I'm not sure it should be reactive to the theme changes. On a separate note though... I'll ask the Design System folks for an opinion and get back to you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9584
Changes proposed in this Pull Request
Note
We'll await design approval of these changes before proceeding
Links and highlights on the Payments → Overview screen will now use custom admin themes, if enabled. Hard-coded colors have been removed, where appropriate, replaced with the CSS var
--wp-admin-theme-color, falling back to$gutenberg-blueif not set.Before/after of WPCOM (WooExpress) store with custom admin color theme "Classic Dark"
Before/after with custom admin color theme "Sunset" enabled
More before/after with custom admin color theme "Sunset" enabled.
Before/after of default theme
Note
There is a slight brightening of the tooltip highlight text color, but it is now consistent with the rest of the page accents
Testing instructions
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge